[Messenger] Transport not mandatory #10092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Marko! I agree this is important. Instead of adding a note below, I propose to reword the introduction so we can tell about this to the reader as soon as possible. |
sroze
approved these changes
Jul 19, 2018
messenger.rst
Outdated
| most of the AMQP brokers such as RabbitMQ. | ||
| By default, messages are processed as soon as they are dispatched. If you prefer | ||
| to process messages asynchronously, you must configure a transport. These | ||
| transports communicate your application with queuing systems or third parties. |
There was a problem hiding this comment.
- communicate your application with queuing systems
+ communicate with your application via queuing systems
|
Thank you @kunicmarko20! |
|
Thank you @javiereguiluz, it is a lot better now! |
|
Thanks Marko. |
javiereguiluz
added a commit
that referenced
this pull request
Jul 19, 2018
…reguiluz) This PR was merged into the 4.1 branch. Discussion ---------- [Messenger] Transport not mandatory After reading the documentation a few days ago I thought that async is the only way this library works, after seeing the discussion today in #general on slack, @sroze explained it. Hopefully, this will help others if they find themselves in the same problem. Commits ------- 47e275b Reword f0942d2 Reword bdbe542 Transport not mandatory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading the documentation a few days ago I thought that async is the only way this library works, after seeing the discussion today in #general on slack, @sroze explained it. Hopefully, this will help others if they find themselves in the same problem.